-
Notifications
You must be signed in to change notification settings - Fork 710
bindir-method/install-method, installdir, new-install flags in SavedConfig -- 3.0 version #5870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cabal-install/Distribution/Client/CmdInstall/ClientInstallFlags.hs
Outdated
Show resolved
Hide resolved
I briefly tested this one empirically and it looks good so far; I haven't done a proper code-review yet though |
Hmm this doesn't seem to build on Windows :(
AppVeyor is showing the error too. |
as pointed out in haskell#5870 (comment)
Thanks @fgaz, @hvr , it compiles now. A couple of observations:
Which led me to believe the binary was in
So we'll need to pick a working default, maybe recommend people try a different
Which failed because |
b49baff
to
60e3de9
Compare
@Mistuke could you try now? edit: nevermind, I can use appveyor |
0feb8ac
to
5100987
Compare
5100987
to
a8a5f15
Compare
Tested on windows, ready for review. Docs update coming shortly. editing this comment so I don't spam everyone: travis is red because I forgot [ci skip] on the last 2 commits and stopped it manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo minor comments.
72e1a9e
to
1122d50
Compare
Rebased against master. |
Yeah I guess, assuming it's the same patches but just backported -- I haven't looked at it. |
Add an --install-method=symlink|copy flag which specifies how to perform the installation. * --symlink-bindir is now gone, replaced by --installdir * --install-method=copy is useful in Windows where symlinking is not supported All new-install flags can now be configured in ~/.cabal/config * NewInstallFlags changed to ClientInstallFlags (more descriptive than InstallExFlags (like ConfigExFlags)) * ClientInstallFlags is now part of SavedConfig
some platforms need an extension for executables Fixed how we get the bindir too.
Since we are working with units, not packages
1122d50
to
a0480d4
Compare
The error is a timeout. Merging. |
TODOs:
Closes #5644
Closes #5837
Closes #5843
/cc @hvr