Skip to content

Bump Cabal versions from 2.5 -> 3.0 #5915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2019
Merged

Bump Cabal versions from 2.5 -> 3.0 #5915

merged 2 commits into from
Mar 9, 2019

Conversation

hvr
Copy link
Member

@hvr hvr commented Mar 3, 2019

NOTE: This will most certainly fail at CI because of the cabal-testsuite.cabal requiring a bleeding edge lib:Cabal for its Setup.hs -- I can't find the ticket, but there's a a plan to decouple cabal-testsuite from requiring a bleeding edge lib:Cabal (UPDATE: see #5916)

Another (less ideal) workaround would be to use a cabal 3.0.* executable for building cabal-testsuite

Addressing #5819

@phadej
Copy link
Collaborator

phadej commented Mar 3, 2019

cabal-testsuite indeed failed on appveyor

@hvr hvr mentioned this pull request Mar 3, 2019
@bgamari
Copy link
Contributor

bgamari commented Mar 4, 2019

On what sort of timeframe can we expect this to be merged? Perhaps it would make sense for GHC to just start tracking this branch?

@hvr
Copy link
Member Author

hvr commented Mar 4, 2019

@bgamari we could push the commit from this PR together with a instant-revert-followup-commit to master, and then you could refer to that; using this branch would be dangerous as there's no guarantee the commit 971f083 will remain reachable and then you'd end up with a broken gitlink in ghc.git

@bgamari
Copy link
Contributor

bgamari commented Mar 5, 2019

@hvr, we could do that but we'll need to sort out #16378 before we can do so.

@hvr
Copy link
Member Author

hvr commented Mar 6, 2019

@bgamari can that very backpack failure be reproduced with GHC 8.6? or is it really a function of the GHC version and specific to GHC 8.8?

@hvr hvr force-pushed the pr/cabal-ver-3 branch 3 times, most recently from 774a202 to 1c12c57 Compare March 7, 2019 08:30
@23Skidoo
Copy link
Member

23Skidoo commented Mar 8, 2019

This is green, time to merge?

@hvr hvr force-pushed the pr/cabal-ver-3 branch 2 times, most recently from 9be552e to 55b4eda Compare March 9, 2019 09:38
This might require more refinement in future and is a first
iteration trying to address haskell#5916
@hvr hvr force-pushed the pr/cabal-ver-3 branch from 55b4eda to 66b9936 Compare March 9, 2019 10:13
@hvr hvr merged commit 382a771 into haskell:master Mar 9, 2019
@hvr hvr deleted the pr/cabal-ver-3 branch March 9, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants