Correct store-dir dir in ghc env files generated by cabal install --lib --package-env

[jneira]

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.

It should fix #5925 and help to fix DanielG/cabal-helper#83

Tested manually running the command and check that the package env file contains the custom store-dir:

PS D:\dev\ws\haskell\cabal-test> cabal install --lib --package-env .
Wrote tarball sdist to
D:\dev\ws\haskell\cabal-test\dist-newstyle\sdist\cabal-test-0.1.0.0.tar.gz
Resolving dependencies...
Up to date
PS D:\dev\ws\haskell\cabal-test> type .\.ghc.environment.x86_64-mingw32-8.6.5
clear-package-db
global-package-db
package-db C:\Users\atrey\AppData\Roaming\cabal\store\ghc-8.6.5\package.db
package-id ghc-8.6.5
....
PS D:\dev\ws\haskell\cabal-test> D:\bin\cabals\3.1.0.0\cabal install --lib --package-env .
Wrote tarball sdist to
D:\dev\ws\haskell\cabal-test\dist-newstyle\sdist\cabal-test-0.1.0.0.tar.gz
Resolving dependencies...
Up to date
PS D:\dev\ws\haskell\cabal-test> type .\.ghc.environment.x86_64-mingw32-8.6.5
clear-package-db
global-package-db
package-db C:\sd\ghc-8.6.5\package.db
....

[DanielG]

The fix itself looks good, but this makes me think the usage of globalFlags in v2 commands is a general code smell. Particularily mlogsDir = flagToMaybe (globalLogsDir globalFlags) just below your patch looks wrong too. ProjectOrchestration.hs uses projectConfigLogsDir when calling mkCabalDirLayout instead. I recon we should do the same thing here.

[jneira]

@DanielG agree, it is done!

[DanielG]

Windows build is failing, not sure what's going on there. @jneira can you try reproducing that locally since you're on windows anyways?

[jneira]

I don't know in deep cabal test suite but i've executed cabal v2-build T4288 inside cabal-testsuite\PackageTests\NewBuild\T4288 with the pr cabal version and the 3.0.0.0 release and the output is identical: https://gist.github.com/jneira/f13ad285b8aaf29ed7909236d64bc9dc

I've triggered an appveyor build in my repo: https://ci.appveyor.com/project/jneira/cabal/builds/28191270

[jneira]

The test was succesful in the appveyor build in my repo: https://ci.appveyor.com/project/jneira/cabal/builds/28191270#L1953

[phadej]

Please, remove the Trigger ci build commit. There are people who are able to click "restart job" if needed.

[phadej]

Remove empty commits.

[jneira]

Oh, sorry for that, commit removed

[jneira]

@phadej does the pr need some other change?

[jneira]

Thanks for the feedback! Glad to having been able to contribute my 2 cents.

[phadej]

This PR is a mess, is the 9e0ab3b right commit to backport? I'm waiting for the response until tomorrow.

[jneira]

@phadej yeah, 9e0ab3b has the needed changes