-
Notifications
You must be signed in to change notification settings - Fork 711
Correct store-dir dir in ghc env files generated by cabal install --lib --package-env
#6298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The fix itself looks good, but this makes me think the usage of |
@DanielG agree, it is done! |
Windows build is failing, not sure what's going on there. @jneira can you try reproducing that locally since you're on windows anyways? |
I don't know in deep cabal test suite but i've executed I've triggered an appveyor build in my repo: https://ci.appveyor.com/project/jneira/cabal/builds/28191270 |
The test was succesful in the appveyor build in my repo: https://ci.appveyor.com/project/jneira/cabal/builds/28191270#L1953 |
Please, remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove empty commits.
Oh, sorry for that, commit removed |
@phadej does the pr need some other change? |
Thanks for the feedback! Glad to having been able to contribute my 2 cents. |
…ckage-env` (haskell#6298) Use project config instead of global one to get store-dir and logs-dir. Fixes haskell#5925 (cherry picked from commit 9e0ab3b)
This PR is a mess, is the 9e0ab3b right commit to backport? I'm waiting for the response until tomorrow. |
…ckage-env` (haskell#6298) Use project config instead of global one to get store-dir and logs-dir. Fixes haskell#5925
Please include the following checklist in your PR:
It should fix #5925 and help to fix DanielG/cabal-helper#83
Tested manually running the command and check that the package env file contains the custom
store-dir
: