Backport fix for dropExeExtension to 3.0 branch #6300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows dropExeExtension doesn't actually drop the exe extension.
We have
splitExtension "foo.exe" == ("foo", ".exe")
but the code is expecting just "exe" for the extension field.
Among other things this makes guessToolFromGhcPath behave
unexpectedly. Since takeVersionSuffix can't see past the extension the
`null suf` case in mkGuesses will trigger which causes the versioned
program path candidates to not be looked for.
|
I did not know about that commit. I don't see why this fix would regress it though? Doesn't look like it's even using dropExeExtension anywhere. You might be thinking of one of the earlier revisions of my fix where I modify It looks like unlike my fix you didn't include a regression test so who can say. If you want your fixes to stay fixed that might well be a thing to do ;) |
|
Ping. CI Looks green apart from a windows failure which exists on Windows: |
looks like a failure in |
|
Backported as in bf862b8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6287 onto 3.0.
I would appreciate it if we could get a
lib:Cabalpoint release for this out. I depend on it over in cabal-helper.