-
Notifications
You must be signed in to change notification settings - Fork 710
Backpack documentation in the user manual. #7306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #4761 Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
Fixes #4761 Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: b220e55 Pull Request resolved: #7306
/cc @cartazio |
Yay! Is there a good way to look at a preview render? |
I don't know! It's been a while. It looks like making this a stack diff also broke CI, so I might need to reopen this PR differently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ezyang. What's this stack diff you're talking about?
It looks like there's a bad hyperlink in here. Building locally, i get the following:
The first warning is seen on |
this alone is a great start! (thx for the render) some questions: which parts of the linked ghc docs are "stable specs" of how things do or dont work across the matrix of ghc and cabal versions? (eg, whats the min version of cabal/ghc needed for various features we do have, and for various limitations/bugs to be avoided?) |
Fixes #4761 Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
Fixes #4761 Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 957ba1d Pull Request resolved: #7306
@emilypi I fixed them! Thanks for reminding me to run the local build. @cartazio Fortunately, Backpack feature development has very much been "no more new features after I finished my PhD". So basically any version of GHC after Backpack was put in is good. There is a Cabal parser that was fixed later but it's already prominently called out in the documentation. Not sure if this is satisfying to you! |
@ezyang did you mean to close this? |
yeah, due to technical difficulties I can only land ghstack PRs by closing, not "merging" |
Can we delete the |
yeah (and I recently fixed ghstack to automatically delete the branches) |
Fixes haskell#4761 Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 957ba1d Pull Request resolved: haskell#7306
Fixes haskell#4761 Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 957ba1d Pull Request resolved: haskell#7306
Stack from ghstack:
Fixes #4761
Signed-off-by: Edward Z. Yang [email protected]