Skip to content

Backpack documentation in the user manual. #7306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Feb 25, 2021

Stack from ghstack:

Fixes #4761

Signed-off-by: Edward Z. Yang [email protected]

Fixes #4761

Signed-off-by: Edward Z. Yang <[email protected]>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Feb 25, 2021
Fixes #4761

Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: b220e55
Pull Request resolved: #7306
@ezyang ezyang requested review from phadej and hvr February 25, 2021 22:04
@fgaz
Copy link
Member

fgaz commented Feb 26, 2021

/cc @cartazio

@cartazio
Copy link
Contributor

Yay! Is there a good way to look at a preview render?
thus is great!

@ezyang
Copy link
Contributor Author

ezyang commented Feb 26, 2021

I don't know! It's been a while. It looks like making this a stack diff also broke CI, so I might need to reopen this PR differently.

emilypi
emilypi previously approved these changes Feb 26, 2021
Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ezyang. What's this stack diff you're talking about?

@emilypi emilypi dismissed their stale review February 26, 2021 17:52

found errors building locally

@emilypi
Copy link
Member

emilypi commented Feb 26, 2021

It looks like there's a bad hyperlink in here. Building locally, i get the following:

WARNING: You are using pip version 20.1.1; however, version 21.0.1 is available.
You should consider upgrading via the '/Users/emilypi/haskell/cabal/.python-sphinx-virtualenv/bin/python3.7 -m pip install --upgrade pip' command.
Running Sphinx v3.1.2
loading pickled environment... done
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 1 source files that are out of date
updating environment: 0 added, 6 changed, 0 removed
reading sources... [100%] setup-commands                                                                                                                                                                   
/Users/emilypi/haskell/cabal/doc/cabal-package.rst:2139: WARNING: invalid pair index entry '; package.cabal field'
/Users/emilypi/haskell/cabal/doc/cabal-project.rst:2: WARNING: Duplicate ID: "cfg-field-type".
/Users/emilypi/haskell/cabal/doc/file-format-changelog.rst:161: WARNING: Unknown target name: "backpack".
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] setup-commands                                                                                                                                                                    
generating indices...  genindex cabal-projectindexdone
writing additional pages...  searchdone
copying static files... ... done
copying extra files... done
dumping search index in English (code: en)... done
dumping object inventory... done
build succeeded, 3 warnings.

The first warning is seen on master, but the rest are related to this PR. I sense a conflict. It would be nice to not add additional warnings if we can, but, since they are warnings, I can run through and fix it up after this PR. Your choice! I built the docs locally and everything renders appropriately:

image
image

@cartazio
Copy link
Contributor

this alone is a great start! (thx for the render)

some questions: which parts of the linked ghc docs are "stable specs" of how things do or dont work across the matrix of ghc and cabal versions? (eg, whats the min version of cabal/ghc needed for various features we do have, and for various limitations/bugs to be avoided?)

Fixes #4761

Signed-off-by: Edward Z. Yang <[email protected]>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Feb 28, 2021
Fixes #4761

Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: 957ba1d
Pull Request resolved: #7306
@ezyang
Copy link
Contributor Author

ezyang commented Feb 28, 2021

@emilypi I fixed them! Thanks for reminding me to run the local build.

@cartazio Fortunately, Backpack feature development has very much been "no more new features after I finished my PhD". So basically any version of GHC after Backpack was put in is good. There is a Cabal parser that was fixed later but it's already prominently called out in the documentation. Not sure if this is satisfying to you!

@ezyang ezyang closed this in 07d6890 Feb 28, 2021
@emilypi
Copy link
Member

emilypi commented Feb 28, 2021

@ezyang did you mean to close this?

@ezyang
Copy link
Contributor Author

ezyang commented Feb 28, 2021

yeah, due to technical difficulties I can only land ghstack PRs by closing, not "merging"

@fgaz
Copy link
Member

fgaz commented Mar 3, 2021

Can we delete the gh/ezyang/1 branches?

@ezyang
Copy link
Contributor Author

ezyang commented Mar 3, 2021

yeah (and I recently fixed ghstack to automatically delete the branches)

@fgaz fgaz deleted the gh/ezyang/1/head branch March 3, 2021 20:45
hololeap pushed a commit to hololeap/cabal that referenced this pull request Apr 24, 2022
Fixes haskell#4761

Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: 957ba1d
Pull Request resolved: haskell#7306
hololeap pushed a commit to hololeap/cabal that referenced this pull request Apr 24, 2022
Fixes haskell#4761

Signed-off-by: Edward Z. Yang <[email protected]>

ghstack-source-id: 957ba1d
Pull Request resolved: haskell#7306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants