-
Notifications
You must be signed in to change notification settings - Fork 711
Set exe as default component for cabal run
and cabal list-bin
#7408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set exe as default component for cabal run
and cabal list-bin
#7408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not test it, but the code looks good! I like how the names are more consistent now
219fffc
to
cc5bd6f
Compare
@dminuoso: the topic starts with [WIP] --- is it ready for final review and merge in your opinion? Do you need any extra help? |
@Mikolaj Hi, I was waiting for @phadej to weigh in on #7403 (comment) But we can merge this already if you like. If phadej agrees to align list-bin with run wrt to implicit packages, I can make a separate PR. |
cabal run
and cabal list-bin
cabal run
and cabal list-bin
@phadej, could you weigh in? :) |
Well, whatever the choice for list-bin is, we can merge this anyway, no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I guess a changelog entry wouldn't hurt, though one can argue this is neither a surprising nor crucial change to how cabal operates.
Ugh, CI apparently got stuck and so the PR got stuck. Let me try to move this forward. |
@Mergifyio rebase |
cc5bd6f
to
2a066b8
Compare
✅ Branch has been successfully rebased |
2a066b8
to
3d3986f
Compare
Resolves #7403
The modification was tested against https://github.com/dminuoso/cabal-repro and the added integration test.
Documentation will be updated tomorrow.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!