Add AmbiguityResolver to decide how to resolve ambiguity #7482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --pick-first-target flag Every other command defaults to what they used to do. show-build-info now just chooses the first choice, since it doesn't care about ambiguity.
This was referenced Jul 12, 2021
jneira
reviewed
Jul 20, 2021
| @@ -685,6 +688,13 @@ configureExOptions _showOrParseArgs src = | |||
| (reqArg "always|never|ghc8.4.4+" | |||
| writeGhcEnvironmentFilesPolicyParser | |||
| writeGhcEnvironmentFilesPolicyPrinter) | |||
|
|
|||
| , option [] ["pick-first-target"] | |||
| ("If there's an amibguity in the target selector, then resolve it by" | |||
mergify
bot
added
the
merge delay passed
ulysses4ever
removed
the
merge delay passed
|
Hello, I am going through old PRs to check whether they are stale. If this PR is still “live”, write a comment and I will remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --pick-first-target flag
Every other command defaults to what they used to do.
Extracted from #7478
Not entirely sure about the purpose, extracted relevant changes and leaving this here so if somebody cares about it, they can pick it up from here.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!