Skip to content

don't consider test flags in reconfigure check #7614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

gbaz
Copy link
Collaborator

@gbaz gbaz commented Sep 2, 2021

Resolves #6267 and #6114

This is a conservative cut at which flags to ignore, on the grounds its better to be safe than sorry. It can always be expanded based on other requests.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many time saved with so few lines, really amazing

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbaz gbaz added the merge me Tell Mergify Bot to merge label Sep 2, 2021
@gbaz gbaz merged commit 9ef1331 into master Sep 2, 2021
@gbaz gbaz deleted the gb/no-reconfigure-test-flags branch September 2, 2021 21:53
@jneira jneira linked an issue Sep 3, 2021 that may be closed by this pull request
@andreasabel
Copy link
Member

Horray for this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Options that change how tests are run should not cause a rebuild
4 participants