-
Notifications
You must be signed in to change notification settings - Fork 710
Add CI dogfood test; only Windows for this PR #7653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1fbe4d7
to
52de3fa
Compare
08e3845
to
ab577da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the script could be simplified using a matrix of ghc versions.
It could be a separate job which can use the cabal built in the actual one via upload/download artifacts
But those things can be done in new prs after this
Thanks!
Yep, fully agreed, there is even a ticket about a part of what you said (#7655). :) Edit: Also, we should have dogfooding for linux and macos as well, more than 2 GHCs tested for Windows and macos, script generating code moved out of the common code base and generally the CI needs a lot of work. |
@Mergifyio backport 3.6 |
Command
|
This has been backported to 3.6 via a direct push to the branch. |
I guess I mistakenly removed it when resolving a conflict in backport of haskell#7653 in c3354c9, because on master these omitted lines are absent. BTW, this backport was not reviewed, by my mistake. A good example why careful reviews are essential.
Bring back cabal-install-dev call removed by backport of #7653
A part of the effort to prevent hiccups like #7649.
I've tested that it fails with 3.6, works after reverting the offending autoconf PR, once the new CI jobs are merged, I will test if the new autoconf fix passes with it.
I've also fixed some details in he previous CI jobs from the workflow and bumped cabal used for bootstrapping from 3.2 to 3.4 in order to make
list-bin
available, needed for the dogfooding jobs.Citing IRC: