-
Notifications
You must be signed in to change notification settings - Fork 710
Generate Paths_ module with qualified Data.List.last import (backport #7650) #7656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This bot is pretty slick! |
I've dismissed my review, because something is wrong in CI and this needs a look. |
The bootstrap CI failure is really misterious, because the changes between 3.6 and master for the related files seem completely irrelevant to it:
So let me rerun the job instead of debugging further. |
Got it! I've rerun the same "linux bootstrap" job for the PR being backported (https://github.com/haskell/cabal/runs/3633407832) and it failed the same on master. So GihHub Actions just switched off 8.10.4. I will try to bump the boostraps to 8.10.7 and see if it works then. |
The bootstrap fix is merged with #7657 so rebasin |
(cherry picked from commit cf6f3fc)
Command
|
632ee05
to
b278960
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix for this nasty bug
This is failing due to #7649 so any pr in 3.6 needs #7652 backported https://github.com/haskell/cabal/runs/3640445372?check_suite_focus=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI failures are as expected at this stage of 3.6 CI fixing.
This is an automatic backport of pull request #7650 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/