Skip to content

Revert "Change cabal-plan list-bin to cabal list-bin in Makefile" #7675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Sep 21, 2021

Reverts #7648

The replacement of cabal-plan list-bin by cabal list-bin did not work for macOS.
Details see #7648 (comment).

@jneira
Copy link
Member

jneira commented Sep 22, 2021

@andreasabel hi, it would be great to have a dedicated bug report about as the idea would be to fix it imo. Reverting the change could be considered if the fix cant be included in the next 3.6 release. And not sure if it should be reverted in master if we want to work on it. Sorry if a i am missing some discussion or additional infor about

@andreasabel
Copy link
Member Author

@jneira : The merged PR only affects developers (only macOS?) so I propose to revert it now and get us back into a good state where we can start investigating the underlying problem.

A change to a developer-only goal in the Makefile isn't something that is relevant for the release, I'd say.

@jneira
Copy link
Member

jneira commented Sep 22, 2021

A change to a developer-only goal in the Makefile isn't something that is relevant for the release, I'd say.

Agree, did not consider the scope of the change well, we will have to remember rerevert it though

Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #7648 (comment)

I also opened #7679

@fgaz fgaz added the merge me Tell Mergify Bot to merge label Sep 22, 2021
@mergify mergify bot merged commit cb98024 into master Sep 22, 2021
@fgaz fgaz deleted the revert-7648-remove-cabal-plan-from-makefile branch September 22, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants