-
Notifications
You must be signed in to change notification settings - Fork 710
Log package hash inputs file and contents / regression test for #6906 #7759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fa7c237
Debug package hash inputs
jneira 83267af
Add test skeleton for #6906
jneira c2f2a7c
Improve output of hash inputs
jneira b36e398
Add tests over pks hash inputs
jneira c388ef9
Correct typos and formatting
jneira ce484be
Add missing do
jneira 9ed92cc
Add missing cabal result arg
jneira 45d19e8
Make consistent log about hash.txt
jneira f7730e1
Update log msg creating file
jneira 568033b
Change var name to hashFileName
jneira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
extra-include-dirs: foo | ||
extra-lib-dirs: bar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
packages: . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import Test.Cabal.Prelude | ||
|
||
main = cabalTest $ do | ||
res <- cabalG' ["--config=cabal.config"] "v2-install" ["-v3"] | ||
assertOutputContains "creating file with the inputs used to compute the package hash:" res | ||
assertOutputContains "extra-lib-dirs: bar" res | ||
expectBroken 6906 $ assertOutputDoesNotContain "extra-lib-dirs: bar bar" res | ||
assertOutputContains "extra-include-dirs: foo" res | ||
expectBroken 6906 $ assertOutputDoesNotContain "extra-include-dirs: foo foo" res |
12 changes: 12 additions & 0 deletions
12
cabal-testsuite/PackageTests/Regression/T6906/issue6906.cabal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
cabal-version: 3.0 | ||
name: issue6906 | ||
version: 0 | ||
synopsis: No duplicate entries for extra-*-dirs config options in the inputs used to compute the package hash | ||
description: When informed in the global config | ||
author: Javier Neira | ||
category: Tests | ||
maintainer: [email protected] | ||
|
||
executable issue6906 | ||
build-depends: base | ||
main-is: main.hs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
main = putStrLn "Hello issue6906" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.