fix list-bin to only choose the selected component

[larskuhtz]

This PR resolves #7679. Currently, at least under certain circumstances, list-bin selects all executable components (including tests and benchmarks) from a package that matches the target selector. This PR fixes this by only selecting the component that match the component name that matches the target selector.

Current behavior:

> cabal list-bin cabal-testsuite:exe:cabal-tests
cabal: No or multiple targets given

Behavior with this PR:

> $(cabal list-bin cabal-install:cabal) list-bin cabal-testsuite:exe:cabal-tests
/Users/lars/Code/github/cabal/dist-newstyle/build/x86_64-osx/ghc-9.0.1/cabal-testsuite-3/build/cabal-tests/cabal-tests

NOTE: during the final selection only the component names but not the component kind are matched. If a package contains two components of different kind, but with the same name (not sure if that is possible), the wrong component might be selected.

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

[fgaz]

Looks good bar comments!

This will need a changelog entry and at least a regression test. Since the logic to test is in listBinAction and not in select*, it will have to be a package test

[Mikolaj]

The CI failures seem random, so probably everything is fine.

[Mikolaj]

@larskuhtz: great, so with a changelog and some minimal test we could merge. Let us know if you need any help with those.

[Mikolaj]

@larskuhtz: ping?

[mouse07410]

May I ask what's preventing merge of this PR?

[larskuhtz]

Sorry, for not getting back earlier. I am not familiar with writing tests for cabal commands. I can give it a try, but if someone else wants to do it that would be welcome, too.

[Mikolaj]

No volunteers, it seems. ;) Please ask questions on Matrix/IRC or here. We'll try to help. I guess a couple of cases (that would fail previously, but work now), with automatically recorded outcomes, in cabal-testsuite/ should be enough and should be relatively easy to copy-paste and amend (and automatically record the results; see the README there). If anybody has a better idea for the test, please yell (I've learned this single test tool and I'm quite ignorant of the other testing mechanisms we do use elsewhere in cabal).

[bacchanalia]

@larskuhtz if you can create a simple cabal project that replicates the failure I can add it as a test for you

[Mikolaj]

@bacchanalia: yay, thank you!

[robx]

Just ran into this bug myself, here's a reduced example that should be suitable for a test case:

$ find .
.
./cabal-testsuite
./cabal-testsuite/cabal-testsuite.cabal
./cabal.project
$ cat cabal.project
packages: cabal-testsuite/
$ cat cabal-testsuite/cabal-testsuite.cabal 
cabal-version: 2.2
name:          cabal-testsuite
version:       3

executable cabal-tests

executable setup

custom-setup
$ cabal list-bin cabal-testsuite:exe:cabal-tests
cabal: No or multiple targets given

[jneira]

Just ran into this bug myself, here's a reduced example that should be suitable for a test case:

ping @bacchanalia

[bacchanalia]

@larskuhtz I've rebased your pr and added the test case @robx posted. Could you give me permissions to push it to your branch? Or would you prefer I sent you a PR?

[larskuhtz]

@bacchanalia you now have write access to https://github.com/hackage-package-forks/cabal

Thanks a lot for moving this PR forward!

[Mikolaj]

Splendid teamwork.

[Mikolaj]

Could we have a minimal changelog file, too?

[bacchanalia]

I added a changelog file. Is this good to merge?

[Mikolaj]

@Mergifyio rebase

[mergify]

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
hackage-package-forks needs to authorize modification on its head branch.
err-code: 9D77C

[Mikolaj]

@bacchanalia: looks good, but could you rebase once last time?

[bacchanalia]

rebased

[mouse07410]

Guys, great work!

Any idea when it will become a release? I.e, efficient version would include this fix?

[Mikolaj]

@mouse07410: hi! I bet it will be in cabal 3.8. No release date yet.