Skip to content

Rebased version of #6703: Remove v2- prefix from command, package, and project docs. #8020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 10, 2022
Merged

Rebased version of #6703: Remove v2- prefix from command, package, and project docs. #8020

merged 5 commits into from
Mar 10, 2022

Conversation

jneira
Copy link
Member

@jneira jneira commented Feb 28, 2022 •
edited
Loading

// @m-renaud feel free to use those changes to rebase yours, other alternative could be close #6703 and merge this

m-renaud and others added 2 commits February 28, 2022 11:24
@m-renaud @jneira
Remove v2- prefix from docs.
bbb07cc 
The v2- style commands have been default since version 3.0.0.0, so when looking
at the latest version of the docs it should assume the defaults. I left the
explicit v2- prefix in the nix-style docs since it is explicitly discussing the
difference between the old and new style commands.

Also fix some small errors.
@jneira
Remove unnecesary note
7cc6485
@jneira
Copy link
Member Author

jneira commented Feb 28, 2022

Like all prs a rendered version of changed docs can be chacked here: https://cabal--8020.org.readthedocs.build/en/802

@jneira
Copy link
Member Author

jneira commented Mar 1, 2022

@Mikolaj as @m-renaud work is honoured in the pr commits and they might be busy i think we could review and merge this

@jneira jneira requested a review from Mikolaj March 1, 2022 07:08
@jneira jneira mentioned this pull request Mar 1, 2022
Closed
Mikolaj
Mikolaj approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. LGTM.

@jneira jneira requested a review from gbaz March 1, 2022 09:30
robx
robx approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@robx robx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, couple minor comments.

jneira and others added 2 commits March 10, 2022 14:17
@jneira jneira merged commit 9f58415 into haskell:master Mar 10, 2022
@jneira
Copy link
Member Author

jneira commented Mar 10, 2022

@robx @Mikolaj thanks for the feedback, merged!

@Mikolaj
Copy link
Member

Mikolaj commented Mar 10, 2022

@jneira: thank you!

This was referenced Jul 5, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robx robx robx approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

@gbaz gbaz Awaiting requested review from gbaz

Assignees
No one assigned
Labels
attention: needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jneira @Mikolaj @robx @ulysses4ever @jneira-stratio @m-renaud