Skip to content

Require type field when spec < 3.8 (#8115) #8138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2022

Conversation

cydparser
Copy link
Collaborator

Addresses changes requested in #8115 (comment)


@cydparser cydparser force-pushed the optional-type-3.8 branch 2 times, most recently from fed3ae5 to 97cae8e Compare May 11, 2022 05:16
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for fixing it

@Mikolaj Mikolaj removed the request for review from gbaz May 12, 2022 16:55
@Mikolaj
Copy link
Member

Mikolaj commented May 16, 2022

Let's merge!

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label May 16, 2022
@Mikolaj
Copy link
Member

Mikolaj commented May 16, 2022

@cydparser: you haven't made your branch read-write, so mergifyIO can't rebase and merge: https://github.com/haskell/cabal/pull/8138/checks?check_run_id=6448254990

If you don't mind, please mark the branch as writeable or just rebase and merge manually.

@mergify mergify bot merged commit 731a983 into haskell:master May 16, 2022
@Mikolaj
Copy link
Member

Mikolaj commented May 16, 2022

Thank you!

@cydparser cydparser removed attention: needs-review merge me Tell Mergify Bot to merge labels May 16, 2022
@cydparser cydparser deleted the optional-type-3.8 branch May 17, 2022 04:04
@cydparser cydparser restored the optional-type-3.8 branch May 17, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants