Skip to content

Bump package process dependency version to 1.6.15.0 and move from Cabal to cabal-install #8342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

Mikolaj
Copy link
Member

@Mikolaj Mikolaj commented Aug 4, 2022

This mimics #8279 and is needed due to #8279 (comment)

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Aug 4, 2022
@robx
Copy link
Collaborator

robx commented Aug 5, 2022

Depending on non-GHC-bundled versions of process might lead to similar trouble as described here: https://discourse.haskell.org/t/why-does-ghc-9-2-4-require-process-1-6-13-2/4884/4.

It might be a better idea to do this only for cabal-install instead of Cabal the library.

@ulysses4ever
Copy link
Collaborator

No matter what version of process Cabal depends upon, there will be a version of GHC that is incompatible? In that case, people either update GHC or downgrade Cabal. And on Discourse, they’re saying that 9.2.5 will come with the newer process.

That said, if the idea to only bump cabal-install dependency solves the dreaded ctrl-c problem, maybe that’s the most robust way to go.

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 5, 2022

That said, if the idea to only bump cabal-install dependency solves the dreaded ctrl-c problem, maybe that’s the most robust way to go.

Well, I don't think in this case we'd build Cabal with old process and cabal-install with new. Rather both would use the new process. The only difference would be when somebody is using Cabal, but not cabal-install.

Given that it sounds safer, let me move the bound from Cabal to cabal-install.

@robx
Copy link
Collaborator

robx commented Aug 5, 2022

That said, if the idea to only bump cabal-install dependency solves the dreaded ctrl-c problem, maybe that’s the most robust way to go.

Well, I don't think in this case we'd build Cabal with old process and cabal-install with new. Rather both would use the new process. The only difference would be when somebody is using Cabal, but not cabal-install.

Given that it sounds safer, let me move the bound from Cabal to cabal-install.

The potential problems arise for projects that depend on Cabal the library. E.g. using both Cabal and hspec, which seems quite likely to occur.

@Mikolaj Mikolaj changed the title Bump package process dependency version to 1.6.15.0 Bump package process dependency version to 1.6.15.0 and move from Cabal to cabal-install Aug 5, 2022
@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 5, 2022

@mergify backport 3.8

@mergify
Copy link
Contributor

mergify bot commented Aug 5, 2022

backport 3.8

✅ Backports have been created

@Mikolaj Mikolaj force-pushed the bump-process-to-1.6.15.0 branch 2 times, most recently from 41fdd68 to 8b4ba77 Compare August 9, 2022 18:26
@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 11, 2022

Let me rebase to see if the recent CI workaround unblocks merging.

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 11, 2022

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2022

rebase

✅ Branch has been successfully rebased

@Mikolaj Mikolaj force-pushed the bump-process-to-1.6.15.0 branch from 8b4ba77 to 38f6eb5 Compare August 11, 2022 17:58
In this way we no longer enforce the fixed process in our own
tools (except cabal-install) and third-party tools using Cabal
the library, but given the possibility of deps conflicts,
this less intrusive approach may be better.
@Mikolaj Mikolaj force-pushed the bump-process-to-1.6.15.0 branch from 38f6eb5 to 304c774 Compare August 13, 2022 17:59
@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 15, 2022

This is rather important and our CI is currently broken (probably some infrastructure corruption), so I'm merging and then backporting manually.

@Mikolaj Mikolaj merged commit 8787293 into haskell:master Aug 15, 2022
@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 15, 2022

@mergify backport

@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2022

backport

❌ No backport have been created

No destination branches found

@andreasabel
Copy link
Member

andreasabel commented Oct 27, 2022

Looks like we should release this fix rather soon, maybe as Cabal-3.8.1.1?

@robx wrote:

Depending on non-GHC-bundled versions of process might lead to similar trouble as described here: discourse.haskell.org/t/why-does-ghc-9-2-4-require-process-1-6-13-2/4884/4.

This potential trouble has turned into real trouble in:

@Mikolaj
Copy link
Member Author

Mikolaj commented Oct 27, 2022

Agreed. There is enough fixes already merged or in flight that 3.8.2.0 of all packages makes sense. If anybody volunteers as a release manager for 3.8.2.0, I will help to make the release soon. Otherwise, I will make the release at some point, but not necessarily right now (depending on the other fixes, their workarounds, etc.).

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Oct 29, 2022
@andreasabel
Copy link
Member

@Mikolaj wrote:

Agreed. There is enough fixes already merged or in flight that 3.8.2.0 of all packages makes sense. If anybody volunteers as a release manager for 3.8.2.0, I will help to make the release soon. Otherwise, I will make the release at some point, but not necessarily right now (depending on the other fixes, their workarounds, etc.).

A proper release would likely be taking a couple of months. Alternatively, can we just release this one patch as cabal-install 3.8.1.1? Cabal 3.8.1.0 can be revised to make the conditional process constraint non-restrictive (process -any).

@Mikolaj
Copy link
Member Author

Mikolaj commented Dec 30, 2022

Yes, absolutely. Release checklist is already mostly done (https://github.com/haskell/cabal/wiki/Making-a-release) and some points can be ignored for a minor release like that. I will help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-review merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants