-
Notifications
You must be signed in to change notification settings - Fork 710
don't auto-download in hash validation phase #8769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jneira will be unamused. |
well, let's register the debt with a label 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test would be nice but the regression is pretty bad, and the earlier we merge a fix the better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
@mergify backport 3.10 |
✅ Backports have been created
|
Let me set the label and the backport in the interest of swiftness. We still have 2 days to add a test. |
8bd9f68
to
5497325
Compare
don't auto-download in hash validation phase (backport #8769)
Resolves #8708 and #8706
Sorry, no additional regression test for this.