Do not check PVP on internal targets

[ffaf1]

Internal targets: test-suites or benchmarks.
See #8361 for rationale.

Note that this patch is quite ugly (duplicating allBuildInfo, using list comprehensions, etc.) but we don’t care as everything will be overwritten by a much more sensible reimplementation in #8427.

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary. N/A, since no warning-specific docs in master, but they have been updated in Reimplement cabal check #8427.
• Include manual QA notes if your PR relates to cabal-install.

---

QA Notes

1. fetch any cabal package with a test-suite, say cabal get lentil
2. cd into it
3. in the build-depends section of the test-suite stanza, add an unbounded dependency
4. run cabal check, it should not complain about missing upper bounds

[Mikolaj]

So, is it a good idea to include this in cabal 3.10.2.0? Gershom also says it would be useful for Hackage. Any problems with this idea?

[Kleidukos]

And it needs a change to Cabal as well in order for Hackage to benefit from it.

[Mikolaj]

So, do we backport now? If so, let's do mergify backport 3.10. Actually, this could have been done instead of the backport label and, with some luck, mergify would create the backport after merge, automatically.

[ffaf1]

@mergify backport 3.10

[mergify]

backport 3.10

✅ Backports have been created

• #9012 Do not check PVP on internal targets (backport #9004) has been created for branch 3.10 but encountered conflicts

[Mikolaj]

Uhoh, a merge conflict in the backport. Is it because we should have backported another PR first or is it due to the formatting PR or something yet different?

[ffaf1]

It is fourmolu.