cabal-install: update resolv to 0.2.0.2 #9059
Conversation
jessicah
force-pushed
the
3.10-resolv-0.2
branch
4 times, most recently
from
71ac094 to
61e7e91
Compare
andreabedini
requested review from
andreabedini and
fgaz
and removed request for
andreabedini
jessicah
force-pushed
the
3.10-resolv-0.2
branch
from
61e7e91 to
3cbb134
Compare
|
Also, grepping for |
|
Also, maybe one for #9008? :) |
| @@ -1,6 +1,8 @@ | |||
| import Test.Cabal.Prelude | |||
|
|
|||
| main = cabalTest $ withRemoteRepo "repo" $ do | |||
| skipIf "osx" =<< isOSX | |||
There was a problem hiding this comment.
If you can't get the output of a test to be deterministic, no problem: just exclude it from recording and do a manual test on the output for the string you're looking for. Try to be deterministic, but sometimes it's not (easily) possible.
Since the warning is not part of the test expectations, instead of duplicating the test I think we can just add recordMode DoNotRecord, assertOutputContains "The index-state is set to 2022-01-28T02:36:41Z", and maybe assertOutputDoesNotContain "revert" to the first update call.
There was a problem hiding this comment.
@fgaz I'll see what I can come up with, bit more than I bargained for :p Does that affect all lines in the test, or just for the first of the three tests?
|
@Mergifyio backport 3.10 |
🟠 Waiting for conditions to match
|
|
@jessicah could you retarget to master? |
|
Oh, the bootstrap files are different. I'll open another pr with the changes I suggested edit: according to the release guide we can defer the bootstrap update. i'll open another pr anyway since it looks like only the author can retarget the pr |
|
@fgaz does this mean that this one can be closed, or is this still needed (with changes)? |
|
We can close this |
Fixes #9054
Please include the following checklist in your PR:
Bonus points for added automated tests!