Include the GHC "Project Unit Id" in the cabal store path #9618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alt-romes
force-pushed
the
abi-tag-in-store-path
branch
3 times, most recently
from
c674aed to
644317d
Compare
alt-romes
requested review from
andreabedini,
philderbeast and
Mikolaj
and removed request for
philderbeast
alt-romes
force-pushed
the
abi-tag-in-store-path
branch
from
644317d to
dcf36d2
Compare
alt-romes
force-pushed
the
abi-tag-in-store-path
branch
3 times, most recently
from
65f8722 to
129ec22
Compare
|
Quick question about normalization: I initially wanted to add - when the ghc did indeed have an ABI hash, however, this won't work because the test output must be the same across different GHC versions. So I'm thinking we should just keep and normalize the ABI hash away (thus, no -). An alternative is to always include -, even when there wasn't one... |
alt-romes
force-pushed
the
abi-tag-in-store-path
branch
from
129ec22 to
e6024fd
Compare
|
I've gone ahead and done the latter, to glob the ABI hash as part of the GHC version. This way the normalization is consistent across GHC versions. |
Kleidukos
approved these changes
Jan 17, 2024
mergify
bot
added
the
merge delay passed
- This allows the use of several **API incompatible builds of the same version of GHC** without corrupting the cabal store. - This relies on the "Project Unit Id" which is available since GHC 9.8.1, older versions of GHC do not benefit from this change. [fixes haskell#8114]
This complements the previous commit in order to fix haskell#9326
Mikolaj
force-pushed
the
abi-tag-in-store-path
branch
from
e6024fd to
dd19cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #9325. It changes the store path from e.g. [...]store/ghc-9.8.1 to [..]store/ghc-9.8.1-f7d8.
It is a continuation of #9326 that rebases and finalizes it.
[fixes #8114]