Add test cabal install remote-pkg for #9697 #9707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But |
Because it is still run in a context with a project file I think. |
ulysses4ever
approved these changes
Feb 12, 2024
geekosaur
approved these changes
Feb 12, 2024
|
@mpickering gotcha. It would be worth adding a test for the non-project case then; so we don't get bitten by it again. |
7 tasks
mergify
bot
added
the
merge delay passed
In haskell#9697 we fixed passing local options to cabal install targets, but rebasing accidentally dropped one of the added the tests for that PR, which tested cabal install <target>, where <target> was only available from a remote repository.
Mikolaj
force-pushed
the
wip/romes/9697-nonlocal-test
branch
from
d0bf8f3 to
b1ff71f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9697 we fixed passing local options to cabal install targets, but rebasing accidentally dropped one of the added the tests for that PR which tested cabal install target, where target was only available from a remote repository.