-
Notifications
You must be signed in to change notification settings - Fork 710
Bump version numbers to 3.10.3.0 #9728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm trying to update the bootstrap files with 9.4.8 (instead of 9.4.5) and I'm getting this error:
|
4d87dda
to
f8f6a53
Compare
You need to remove the |
@mpickering thank you. I imagine we should wait for your PR to be merged and then backport it to 3.10? |
In that case, maybe we'd force-merge #9722 before the delay passes? |
I don't think that CI changes are suitable to back-port in general, it is much safer to apply just the changes needed to the CI configuration on the local branch so that there is less potential for change between minor releases. In this case we certainly don't want to copy the bootstrap plans, those are likely to be wrong for the 3.10 branch! |
@mpickering yes, of course. :) |
Ah I think you need to delete 3.4 and 3.6 as well, because 3.8 is the first version where Another way to fix this is to probably delete the explicit |
CI died in the #9700 way. I'd propose to disable this one test on branch 3.10 in this very PR and continue [edit: continue the CI run beyond the failure] (there are some more steps in CI that get cancelled due to this failure). Releasing with a broken CI is unfortunate, but that's only a single test with a relatively old GHC, ao it's likely to be a fluke and releasing promptly has much higher priority IMHO. |
@Mikolaj just so I understand, you approve bypassing the branch protection? |
No, I propose disabling the failing test in the CI script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bump versions to 3.10.3.0