Continue to improve map functions #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite `unionWith`, `intersectionWithKey`, etc., as independent functions. Writing either in terms of the other leads to closures being allocated with extra indirection for the passed function. `mergeWithKey` misses singleton optimizations for unions. For the rest, I think `mergeWithKey` is hard to understand, and it's not immediately obvious how the parts are supposed to fit together. Since it's used only to reduce *source* code size, and not actual *generated* code size, I'd rather avoid it for the most part. I've left `differenceWith` and `differenceWithKey` alone, as they appear to be rather deeply tied to the concepts in `mergeWithKey`.
* Continue set and map combination rewrites. * Add bias tests to `Data.Set` suite. * Replace `Arbitrary` instance for sets. * Use specialized function to produce pairs of sets for combination tests. This is a horribly large and incomplete commit, but it all works and I need to move on to some other things. Sorry, world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite
unionWith,intersectionWithKey, etc., as independentfunctions. Writing either in terms of the other leads to closures
being allocated with extra indirection for the passed function.
mergeWithKeymisses singleton optimizations for unions. For therest, I think
mergeWithKeyis hard to understand, and it's notimmediately obvious how the parts are supposed to fit together.
Since it's used only to reduce source code size, and not actual
generated code size, I'd rather avoid it for the most part.
I've left
differenceWithanddifferenceWithKeyalone, as theyappear to be rather deeply tied to the concepts in
mergeWithKey.