Bump to GHC 8.0 #812
Bump to GHC 8.0 #812
Conversation
treeowl
force-pushed
the
bump-to-8.0
branch
5 times, most recently
from
0bc9f7f to
2becf6e
Compare
containers/src/Data/IntMap.hs
Outdated
|
|
||
| -- | This function is being removed and is no longer usable. | ||
| -- Use 'Data.IntMap.Strict.insertWith' | ||
| insertWith' :: Whoops "Data.IntMap.insertWith' is gone. Use Data.IntMap.Strict.insertWith." |
There was a problem hiding this comment.
While bumping lower bound is just a maintenance thing, the removal of functions is a breaking change.
Why you do them at the same time? Is it time for containers-0.7?
There was a problem hiding this comment.
@phadej I was just thinking in terms of getting rid of cruft. Are you opposed to the change?
There was a problem hiding this comment.
New idea! Let's delete those without a major release. I argue that's okay. The functions were totally disabled anyway, so the disruption of removing them is limited to potentially having to delete them from hiding clauses. This is no worse than the potential disruption of adding functions, which is allowed in minor releases.
There was a problem hiding this comment.
You should removed them in containers-0.6. Removal of symbols whenever they are usable/useful or not is a breaking change, period.
There was a problem hiding this comment.
Concrete and not too contrived example: Someone could still explicitly-re-export these symbols, removal would break that "use"-site.
|
@sjakobi, I reverted the removal of deprecated things. Do you think you can review it now? |
* Raise minimum GHC version to 8.0 so we'll be able to define `Lift` instances, avoid certain conditional definitions, etc. * Raise Cabal version for tests to 2.2; use `common` stanzas.
|
Yay! |
Raise minimum GHC version to 8.0 so we'll be able to define
Liftinstances, avoid certain conditional definitions, etc.Raise Cabal version for tests to 2.2; use
commonstanzas.