Add support for embedding of analytics pixels on package pages #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasabel
reviewed
Mar 30, 2022
andreasabel
requested changes
Mar 30, 2022
alexbiehl
force-pushed
the
scarf-analytics-pixel
branch
2 times, most recently
from
9ac62d3 to
4c083dd
Compare
|
@andreasabel Any chance you can have another look? |
gbaz
reviewed
Apr 27, 2022
alexbiehl
force-pushed
the
scarf-analytics-pixel
branch
2 times, most recently
from
4c083dd to
a1b3f12
Compare
alexbiehl
force-pushed
the
scarf-analytics-pixel
branch
from
a1b3f12 to
42fcc93
Compare
|
Any chance for another round of reviews, @gbaz? |
|
It looks good. I plan to give it a final review and merge before the next redeploy. Just been a bit slammed by other responsibilities! |
|
I merged in preperation for a redeploy, but noticed in testing that the list of pixels already created did not show up properly in the package page. (It does show up in the page that lists all pixels for all packages for a user). So I'm going to comment out links to this functionality for now in the release. A patch fixing that up would be welcome. |
This was referenced Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for package maintainers to attach analytics pixels to one or more of their packages in order to better understand the web traffic to their package pages on Hackage. Specifying an analytics pixel URL will result in Hackage automatically embedding the provided URL in an image tag on the main package page.
Context
This PR comes from a previous discussion that @aviaviavi, @gbaz, and the hackage-admin email group. The original suggestion for the direction in this PR came @davean, in discussion with the Haskell Foundation regarding approaches for introducing more analytical tools for maintainers within Hackage.
What not in this PR
Support for analytics pixels to be embedded in generated Haddock documentation is a natural next step and can be included in a future PR.