List maintainers on package page #1098
Conversation
|
Thanks for the PR!
|
| listGroupCompact :: [Users.UserName] -> Html | ||
| listGroupCompact [] = toHtml "No member exist presently" | ||
| listGroupCompact users = foldr1 (\a b -> a +++ ", " +++ b) (map displayName users) | ||
| where displayName uname = (anchor ! [href $ "/user/" ++ display uname] << display uname) |
There was a problem hiding this comment.
The last line has copy-and-paste code from above. Please factor out the common code.
Yes. However, I don't understand what you mean by "the same terminology". Did you mean moving these links to the Maintainers section in the right? If so, wouldn't it cause confusion between maintainers listed in .cabal file (which may be an email) and hackage maintainers? |
|
As Alias says, the "maintainer" field on the right is a free text field in the cabal file. This "maintainers" is the listing of actual hackage accounts with maintainer rights for the package. So I think it should live where it does, and not on the right. We could rename this new one to "hackage maintainers" or "hackage maintainers group" or something more clarifying... |
|
All I meant is: Here, replace MAINTAINERS by either "maintainers" or "package maintainers", but use the same wording; otherwise one could think that different collections of individuals are meant there. |
|
I think package maintainers will be fine. I'll make a commit quickly. |
|
|
* delete unused GitHub Action; fix CI badge * Fix #1076: separate validators from UI and doctest them (#1077) * Cachix caching for nix-shell GitHub Action (#1081) * Add uploaded_at field in package api (#1080) * package page: Include virtual-modules in module tree (#1085) * Allow hashable-1.4 and text-2.0 (#1089) * Divide sitemap into parts * Add sitemap link for subdirectories * Fix `non-canonical-return` warnings * Bump CI to GHC 9.2.3 and restrict to master branch * Check authorisation (#1111) * Dynamically add css piece * Fix #1105: change order of markdown parsers to allow pipes in lists * Fix #1128, fix #1130 by adding bounds to Cabal-syntax and haddock-library * Bump CI to 9.2.4 and some deps * Force .txt and .text to have UTF-8 MIME charset (#1133) * Upgrade to haddock-library-1.11.0 (#1126) * attempt to speed up GitHub Action for Nix Shell * work with cabal 3.8 * Updated accepted licenses (#1092) * Add dependabot for github workflows * Bump cachix/cachix-action from 10 to 12 * Bump actions/checkout from 2.4.0 to 3.1.0 * Bump cachix/install-nix-action from 17 to 18 * Build with Cabal-3.8 and GHC 9.4 (#1141) * Haskell CI: bump to Ubuntu-22.04, GHC 9.2.5 and 9.4.4 * Allow mtl-2.3 and transformers-0.6 (#1150) * Disable test (#1124) * allow disable tests on client side * add deprecated version warning (#1123) * List maintainers on package page (#1098) * List maintainers on package page * Vendor snowball package (#1116) * Add searchbox metadata (#1115) * Add captcha for user registration (#1099) * remove filtering 00-index for cabal version < 2.0 hack (#1152) * Add lastVersion in listings (#749) (#1140) * rm icu dep instructions, add libgd * Add test log display (#1100) * Add test log * Reverse Dependencies indexed on PackageName (#1082) * Rebased Reverse Dependencies * Add "Quick Jump" to candidate package page (#1122) * Solves #1029 - Adds paging to recent packages and recent revisions (#1055) * support for `prefers-color-scheme` (#1008) * 2x brightness for captions and links in dark color scheme * table dark color scheme * prefers-color-scheme for links, footer, and table-of-contents * paginator css for `prefers-color-scheme` * Maintainer notifications * cleanup partial functions for revdeps, elim use of MonadThrow, MonadCatch * fix tests enablement link Co-authored-by: Peter Becich <[email protected]> Co-authored-by: Andreas Abel <[email protected]> Co-authored-by: Hécate Moonlight <[email protected]> Co-authored-by: Matthew Pickering <[email protected]> Co-authored-by: ˌbodʲɪˈɡrʲim <[email protected]> Co-authored-by: Alias Qli <[email protected]> Co-authored-by: Ondřej Kubánek <[email protected]> Co-authored-by: Gautier DI FOLCO <[email protected]> Co-authored-by: Janus Troelsen <[email protected]> Co-authored-by: Levi Butcher <[email protected]>
This pull request implements issue #637 as a gsoc project mentored by @gbaz. It displays hackage maintainers in Maintainer's Corner, on both package and candidate pages. Looks like this: