-
Notifications
You must be signed in to change notification settings - Fork 200
Notify maintainers when dependency is out of range #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This would be an awesome feature! 🎉 |
toNotify <- traverse maintainersToNotify revDepNames | ||
pure $ | ||
Map.fromList | ||
[ ( maintainerId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens here if multiple packages by the same maintainer are affected by the same release? Ideally, I think the maintainer should get a single notification with a list of those packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I have pushed a commit which groups by userId and packageId. Now the email looks like this:
The dependency transformers-0.6.0.2 has been updated.
You have requested to be notified when a dependency isn't accepted by any of your maintained packages.
These are your packages that require transformers but don't accept 0.6.0.2:
servant-0.19.1
You can adjust your notification preferences at
http://gorm.local:8080/user/admin/notify
Also adds a test which would fail before this commit.
@peterbecich any thoughts on why the nix flake test is consistently failing? |
This test is identical to the second of the assertEquals.
RE nix failure: it's due to Cabal update which didn't take into account the nix setup (#1186). I tried to fix it (ulysses4ever@aa00808) but bumped into a test suite failure (https://github.com/ulysses4ever/hackage-server/actions/runs/4682410347/jobs/8296230988) and i didn't go as far as figuring what's the best way to handle it (e.g. one could probably disable the tests). |
Will look at the Nix error later today. Have you tried |
|
@gbaz I have now double checked everything and I think this is ready for merging! |
Tested by:
UserNotify.hs
to 1 minute[email protected]
mail(1)
from the packagebsd-mailx
that the mail was delivered and the link works