Skip to content

Recognise OtherOS "haiku" as a valid identifier. #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Recognise OtherOS "haiku" as a valid identifier. #1221

wants to merge 1 commit into from

Conversation

jessicah
Copy link
Contributor

OSHaiku will be available in cabal-3.12, and a PR for that change is in #1217. Until then, allow OtherOS "haiku" until cabal can be updated.

@jessicah
Recognise OtherOS "haiku" as a valid identifier.
a75ce6f 
`OSHaiku` will be available in cabal-3.12, and a PR for that change
is in haskell#1217. Until then, allow `OtherOS "haiku"` until cabal can
be updated.
@jessicah
Copy link
Contributor Author

Corresponding PR to cabal: haskell/cabal#9048

@jessicah jessicah mentioned this pull request Jun 20, 2023
Merged
4 tasks
@andreasabel andreasabel self-assigned this Aug 3, 2023
andreasabel pushed a commit that referenced this pull request Aug 3, 2023
@jessicah @andreasabel
haiku: add as known platform
eabf54a 
This combines via CPP two PRs by @jessicah:

- #1217 (for Cabal >= 3.11)
- #1221 (for Cabal <= 3.10)
@andreasabel andreasabel mentioned this pull request Aug 3, 2023
Merged
@andreasabel
Copy link
Member

Thanks, @jessicah, incorporated this in

@andreasabel andreasabel closed this Aug 3, 2023
@jessicah
Copy link
Contributor Author

jessicah commented Aug 3, 2023

@andreasabel ah okay, was hoping to get done sooner, so that dependencies for GHC could be uploaded, as they're still waiting as PRs for a few months now. That was part of the reason for the OtherOS "haiku" patch, so that hackage didn't need to wait for a new major version to cabal.

@andreasabel
Copy link
Member

@jessicah : With eabf54a your PR is now on master.
However, it might take some time to bring it live; hackage.haskell.org is only deployed every couple of months, only @gbaz knows when will be next.

@phadej phadej mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andreasabel andreasabel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicah @andreasabel