Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Bullet-proof installation instructions #409

Closed
saurabhnanda opened this issue Dec 14, 2017 · 9 comments
Closed

Bullet-proof installation instructions #409

saurabhnanda opened this issue Dec 14, 2017 · 9 comments

Comments

@saurabhnanda
Copy link

Over the past week I've directed 4 newbies in my team to the HIE installation instructions and all 4 of them messed it up. I'm just opening this as a reminder for myself. I plan to figure out what went wrong a raise a PR to fix this.

@saurabhnanda
Copy link
Author

Okay, this is what I have, till now. Is this acceptable for a PR: http://www.vacationlabs.com/haskell/environment-setup.html#installing-vscode-hie

@ianchanning
Copy link
Contributor

@saurabhnanda the link that you gave is no longer available. Have you got these instructions anywhere else?

@saurabhnanda
Copy link
Author

@ianchanning we were moving sites and missed out this folder. The earlier link should be up now. Sorry about the trouble.

@ianchanning
Copy link
Contributor

Brilliant - thanks!

@ianchanning
Copy link
Contributor

ianchanning commented Dec 20, 2018

I did some work on the installation process (#998) that's now been merged.

Your article is great and I love the simplicity of:

$ git clone https://github.com/haskell/haskell-ide-engine
$ cd haskell-ide-engine
$ stack install

The only difference is that I was advised that it's better to use the make hie-x.x.x command which is a wrapper on stack install, plus even the default make command doesn't install the hoogle documentation. So I think for your instructions you could switch to:

$ git clone https://github.com/haskell/haskell-ide-engine
$ cd haskell-ide-engine
$ make hie-8.6.2

This would be the same version that stack install would do.

@kritzcreek
Copy link

make is a non-trivial dependency on Windows. So unless it can't be done without that I'd suggest to avoid it in bulletproof installation instructions.

@ianchanning
Copy link
Contributor

I agree that that means there is a different path for Windows (there is a powershell script). But the make file does extra required checks to make it more bullet proof than stack install and is recommendation from the core developers:

The preferred installation mechanism is actually via the makefile, as it makes sure the repo is synced, installs the required cabal libraries if missing, and makes copies of the executables with suffixes to be able to tell them apart.

@Anrock
Copy link
Collaborator

Anrock commented Dec 20, 2018

make is a non-trivial dependency on Windows

That was discussed multiple times and i still think that stack exec -- pacman install make is trivial enough, although still an additional step it takes care of all the extra quirks so user wouldn't have to run them manually. Make dependency will go away with #991, btw.

@alanz alanz added this to the 2019-01 milestone Dec 24, 2018
@alanz alanz modified the milestones: 2019-01, 2019-02 Feb 2, 2019
@alanz alanz modified the milestones: 2019-02, 2019-03 Mar 2, 2019
@Anrock
Copy link
Collaborator

Anrock commented Mar 19, 2019

Makefile support is dropped and README was heavily modified recently. If you found it's still lacking - please open a new issue.

@Anrock Anrock closed this as completed Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants