This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Rename Shakefile.hs to install.hs #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anrock
commented
Jan 11, 2019
| @@ -172,7 +172,7 @@ helpMessage = do | |||
| let out = liftIO . putStrLn | |||
| out "" | |||
| out "Usage:" | |||
| out " stack Shakefile.hs <target>" | |||
| out " stack install.hs <target>" | |||
There was a problem hiding this comment.
@fendor I wonder if hardcoded filename should be replaced with something like argv[0]. I doubt this file would be renamed again anytime soon, but one less place to check is a good thing.
There was a problem hiding this comment.
I agree, that would be better.
In the next 2 weeks I'd like to add various improvements to it.
7 tasks
|
The changes look good, the Readme has also been properly updated and it still works on my machine. |
fendor
approved these changes
Jan 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1033