Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Ormolu 8.8 #1579

Closed
wants to merge 5 commits into from
Closed

Ormolu 8.8 #1579

wants to merge 5 commits into from

Conversation

Avi-D-coder
Copy link
Collaborator

@Avi-D-coder Avi-D-coder commented Jan 20, 2020

This is a possible stop gap, needed until tweag/ormolu#501 lands in hackage.
The alternative is setting allow-newer.

Follow up to #1482

@Avi-D-coder Avi-D-coder requested a review from alanz January 20, 2020 01:21
@jneira
Copy link
Member

jneira commented Jan 20, 2020

Hi! thanks for the quick fix.
I think stack-8.8.1.yaml would need a similar git dependency to work.
Other times we've added the forked project (cabal-helper, hare, etc) to submodules and as local package in build config. Not sure if it can be applied to ormolu.
Personally i am fine with git dependencies

@Avi-D-coder
Copy link
Collaborator Author

My reason for not using a submodule is that only 8.8 needs it. If I'm not mistaken git dependency support in cabal is relatively new, so was not an option before.

@Avi-D-coder Avi-D-coder requested a review from fendor January 20, 2020 06:35
@Avi-D-coder
Copy link
Collaborator Author

Azure Windows_Stack stack-8.4.2 appears to be another instance of #1482 (comment)

@jneira
Copy link
Member

jneira commented Jan 20, 2020

@Avi-D-coder yeah, we could ignore for now the Session time outs

Mmm, Linux_Stack stack-8.8.1 is failing due a slighty diff output:

haskell-ide-engine>   test/functional/FormatSpec.hs:106:23: 
haskell-ide-engine>   1) Format.ormolu formats correctly
haskell-ide-engine>        expected: "module    Format where\nfoo   :: Int ->  Int\nfoo  3 = 2\nfoo    x  = x\nbar   :: String ->   IO String\nbar s =  do\n      x <- return \"hello\"\n      return \"asdf\"\n      \n"
haskell-ide-engine>         but got: "module Format where\n\nfoo :: Int -> Int\nfoo 3 = 2\nfoo x = x\n\nbar :: String -> IO String\nbar s = do\n  x <- return \"hello\"\n  return \"asdf\"\n"
haskell-ide-engine> 
haskell-ide-engine>   To rerun use: --match "/Format/ormolu/formats correctly/"

i guess it is not reproduced in local?

@alanz
Copy link
Collaborator

alanz commented Jan 20, 2020

I suggest we wait a little to give the ormolu guys a chance to respond to their PR, and if not merge this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants