stack ./install.hs installs a bunch of extra executables

[lukel97]

I ran stack ./install.hs hls-8.10.1 and saw this bit of output:

Copied executables to /Users/luke/.local/bin:
- ghcide
- ghcide-bench
- ghcide-test-preprocessor
- haskell-language-server
- haskell-language-server-wrapper

haskell-language-server got symlinked correctly inside ~/local/.bin to haskell-language-server-8.10[.1], but I definitely didn't expect any of the ghcide executables to get installed. Perhaps we should explicitly pass stack install haskell-language-server haskell-language-server-wrapper as args to make sure we only install the specified executables

[mouse07410]

Doesn't haskell-language-server actually use ghcide executable? Or is it just linked to ghcide "library"?

[lukel97]

@mouse07410 it just uses the latter library, and the ghcide-bench/ghcide-test-preprocessor are helper executables that definitely shouldn't be installed. I've had this issue in the past where helper executables get installed with cabal install/stack install, makes me wish there was a cabal stanza field like buildable, except installable. The closest approximation I could get to that was setting buildable: False, but with a cabal flag that's turned on in a cabal.project file that sets buildable: True

[jneira]

stack install function has two branches and only one has the correct targets, fixing!

haskell-language-server/install/src/Stack.hs

Lines 22 to 30 in 35205ee

	Nothing -> do
	execStackWithCfgFile_ "stack.yaml" $
	["install"
	, ":haskell-language-server-wrapper"
	, ":haskell-language-server"] ++ args
	getGhcVersionOfCfgFile "stack.yaml" args
	Just vn -> do
	execStackWithGhc_ vn $ ["install"] ++ args
	return vn