Skip to content

Incorrect rendering of path to function definition on hover in SublimeText #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ShrykeWindgrace opened this issue Jul 23, 2020 · 6 comments
Closed

Incorrect rendering of path to function definition on hover in SublimeText #222

ShrykeWindgrace opened this issue Jul 23, 2020 · 6 comments
Labels
component: ghcide os: windows status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@ShrykeWindgrace
Copy link

ShrykeWindgrace commented Jul 23, 2020 •
edited
Loading

When I hover on a function, the path to its definition is given without path separator characters (screenshot for illustration):
image

Config: Win10-1809, hls.exe from the 0.2.1 release (for GHC-8.10.1). SublimeText4 (4079) with the recommended LSP plugin.
@jneira jneira added component: ghcide os: windows type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. status: needs repro labels Jul 23, 2020
pepeiborra pushed a commit that referenced this issue Dec 27, 2020
@serras @moritzkiefer-da
Support TemplateHaskell (#222)
481ca01 
* First attempt at TH support

* Update TcModuleResult when generating core

* Be a bit more cautious when asking for bytecode

* Check need for bytecode not only in source file itself, also in global information

* Add a test (based on #212)

* Fix test (thanks, @jinwoo)

* Split GenerateCore and GenerateByteCode
@Anton-Latukha
Copy link
Collaborator

Is it already solved? Maybe #222 solved it?

@jneira jneira added the status: needs info Not actionable, because there's missing information label Dec 21, 2021
@ShrykeWindgrace
Copy link
Author

I'm on vacation without access to my devenv; I will be able to look into current rendering of paths not earlier than mid-January.

@jneira jneira removed the status: needs info Not actionable, because there's missing information label Dec 21, 2021
@jneira
Copy link
Member

jneira commented Jan 31, 2022

@ShrykeWindgrace did you get to check if the issue is reproduced? thanks!

@ShrykeWindgrace
Copy link
Author

@jneira thanks for pinging me about this issue, I completely forgot about it (I migrated to VSCode since then). I will try to take a look (this week, most probably; but certainly not today).

@ShrykeWindgrace
Copy link
Author

TLDR: the issue is still there.

image

Config: win10, Sublime Text 4 (4126, latest at the time of writing), HLS-1.6.1.0 for ghc-8.10.7. LSP plugin from https://lsp.sublimetext.io/.

If there is an option that would allow me provide more info, I'm willing to try. I am not entirely sure whether this is an HLS issue or the LSP plugin issue... VSCode renders these paths with backslashes; what does HLS send? forward slashes or backslashes?

@hasufell hasufell added status: needs info Not actionable, because there's missing information and removed old_status: needs repro labels Jul 13, 2022
@michaelpj
Copy link
Collaborator

Tentatively closing as no reports recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide os: windows status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jneira @hasufell @michaelpj @ShrykeWindgrace @Anton-Latukha