Properly name the binaries before gzipping them

[lukel97]

Currently all the binaries are gzipped with the proper name, but when unzipped have the name hls or his-wrapper. They should be named haskell-language-server-8.x.y and haskell-language-server-wrapper respectively

[jneira]

Mainly unrelated but, would it possible that windows binaries will use zip instead gzip? It is the default format in windows.

[lukel97]

@jneira I didn't realise that, that's a good catch!

[dreamsmasher]

Still have sort of a similar problem, the Linux releases are named haskell-language-server-Linux-8.x.x but the wrapper specifically looks for haskell-language-server-8.x.x. I had to manually rename the executable in order to get it to work.

[Ailrun]

I'm wondering why does the workflow script renames executables. Specifically,

haskell-language-server/.github/workflows/build.yml

Lines 37 to 44 in f2384e1

	- name: Shorten binary names
	shell: bash
	run: |
	sed -i.bak -e 's/haskell-language-server/hls/g' \
	-e 's/haskell_language_server/hls/g' \
	haskell-language-server.cabal
	sed -i.bak -e 's/Paths_haskell_language_server/Paths_hls/g' \
	src/**/*.hs exe/*.hs

It looks like this is why we get the different names instead of the proper names...

[fendor]

@Ailrun According to the blog post: https://mpickering.github.io/ide/posts/2020-07-10-ghc-libdir.html
To avoid long path problems on windows.

[Ailrun]

Thank you for the link. Windows path limit... that's annoying... Then we should rename it after the build...

[jneira]

I am afraid that they need to be renamed before the build or the build itself fails.
The final name could be the long one.

[lukel97]

@jneira do you know what command can be used on git bash to zip files on Windows? Just calling zip fails since it doesn't exist: https://github.com/bubba/haskell-language-server/runs/915797336?check_suite_focus=true#step:8:6

I checked the GitHub Actions virtual environment and 7zip seems to be installed, but I'm not sure what the command/executable is

[Ailrun]

@bubba AFAIK, the command for 7zip is 7z.