Skip to content

Stan errors contains terminal color codes #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andys8 opened this issue Aug 11, 2022 · 2 comments
Closed

Stan errors contains terminal color codes #3089

andys8 opened this issue Aug 11, 2022 · 2 comments
Labels

Comments

@andys8
Copy link
Collaborator

andys8 commented Aug 11, 2022

Is your enhancement request related to a problem? Please describe.

Severity and Category use terminal color codes that aren't recognized in Vim/CoC. I assume that's also the case in other editors.

image

Describe the solution you'd like

  • Either allowing stan itself to configure/detect non interactive mode or skip coloring
  • Or filter out color codes in the stan hls plugin

Additional context

Currently using a89ba412293327ec838c00d899ea9c6013c46aa3.

haskell-language-server version: 1.7.0.0 (GHC: 9.2.4) (PATH: /home/andreas/.ghcup/bin/haskell-language-server-wrapper-1.7.0.1)
Tool versions found on the $PATH
cabal:          3.8.1.0
stack:          2.7.5
ghc:            9.2.4

In case the local stan installation is relevant:

Stan v0.0.0.0
 ➤ Git revision: 4fcf2e15d067f652c753272202fb33ef4200ccad
 ➤ Commit date:  Thu Jun 25 18:40:45 2020 +0100

Pinging @uhbif19

andys8 added a commit to andys8/haskell-language-server that referenced this issue Aug 11, 2022
@andys8
Copy link
Collaborator Author

andys8 commented Aug 11, 2022

It's easier than I initially thought. Pretty functions are adding terminal colors and are directly used. Replacing them with show instances solves the issue.

Opened #3090

andys8 added a commit to andys8/haskell-language-server that referenced this issue Aug 11, 2022
@andys8
Copy link
Collaborator Author

andys8 commented Aug 12, 2022

Solved by #3090

@andys8 andys8 closed this as completed Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant