Hackage hls-call-hierarchy-plugin-1.1.0.0 incompatible with hls-1.9

[juhp]

I know the Build from Source instructions say to use git, but just checking whether you plan to upload all the latest deps to Hackage?
Building from Hackage worked for 1.8 and earlier, but maybe you don't intend to support that way anymore?
(In which case I will switch my Fedora HLS build to use git instead, though using Hackage is more reproducible.
Personally, I feel if one day we can get HLS into Stackage that would be even better, but that is probably still far.)

[wz1000]

I did upload to hackage: https://hackage.haskell.org/package/haskell-language-server-1.9.0.0 What did you find missing?

…

On Thu, 29 Dec, 2022, 10:56 Jens Petersen, ***@***.***> wrote: I know the Build from Source instructions say to use git, but just checking whether you plan to upload all the latest deps to Hackage? Building from Hackage worked for 1.8 and earlier, but maybe you don't intend to support that way anymore? (In which case I will switch my Fedora HLS build to use git instead, though using Hackage is more reproducible. Personally, I feel if one day we can get HLS into Stackage that would be even better, but that is probably still far.) — Reply to this email directly, view it on GitHub <#3427>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABEW5URGGIZ6BSGVI7VNXPLWPUOHZANCNFSM6AAAAAATLZVEDY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[maralorn]

I think everything is fine besides a missing update for hls-call-hierarchy-plugin. The released hls-call-hierarchy-plugin is not compatible with hls 1.9.

[juhp]

Okay I think maralorn is right - I was also hitting some unrelated local packaging changes I had made for 1.8...

[juhp]

Specifically Hackage hls-call-hierarchy-plugin-1.1.0.0 requires hls-plugin-api < 1.6

Error: cabal: Could not resolve dependencies:
[__0] trying: haskell-language-server-1.9.0.0 (user goal)
[__1] trying: haskell-language-server:+callhierarchy
[__2] trying: hls-call-hierarchy-plugin-1.1.0.0 (dependency of
haskell-language-server +callhierarchy)
[__3] next goal: hls-plugin-api (dependency of haskell-language-server)
[__3] rejecting: hls-plugin-api-1.6.0.0 (conflict: hls-call-hierarchy-plugin
=> hls-plugin-api^>=1.5)
[__3] rejecting: hls-plugin-api-1.5.0.0 (conflict: haskell-language-server =>
hls-plugin-api^>=1.6)
[__3] skipping: hls-plugin-api-1.4.0.0, hls-plugin-api-1.3.0.0,
hls-plugin-api-1.2.0.2, hls-plugin-api-1.2.0.1, hls-plugin-api-1.2.0.0,
hls-plugin-api-1.1.0.2, hls-plugin-api-1.1.0.1, hls-plugin-api-1.1.0.0,
hls-plugin-api-1.0.0.0, hls-plugin-api-0.7.1.0, hls-plugin-api-0.7.0.0,
hls-plugin-api-0.6.0.0, hls-plugin-api-0.5.0.1, hls-plugin-api-0.5.0.0,
hls-plugin-api-0.4.1.0, hls-plugin-api-0.4.0.0 (has the same characteristics
that caused the previous version to fail: excluded by constraint '^>=1.6' from
'haskell-language-server')
[__3] fail (backjumping, conflict set: haskell-language-server,
hls-call-hierarchy-plugin, hls-plugin-api)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: haskell-language-server,
hls-plugin-api, hls-call-hierarchy-plugin,
haskell-language-server:callhierarchy

[spacekitteh]

Yes, please upload the latest version of the plugin to hackage.

[spacekitteh]

@wz1000

I did upload to hackage: https://hackage.haskell.org/package/haskell-language-server-1.9.0.0 What did you find missing?

https://hackage.haskell.org/package/haskell-language-server-1.9.0.0/reports/2

[wz1000]

Published https://hackage.haskell.org/package/hls-call-hierarchy-plugin-1.2.0.0 and revised HLS (https://hackage.haskell.org/package/haskell-language-server-1.9.0.0/revisions/)

[cumber]

@wz1000 Did that revision to depend on hls-call-hierarchy-plugin ^>= 1.2 ever make it into the actual source? It seems to have reverted to ^>= 1.1 in the hackage release of HLS 1.9.1

[tbidne]

@wz1000 Did that revision to depend on hls-call-hierarchy-plugin ^>= 1.2 ever make it into the actual source? It seems to have reverted to ^>= 1.1 in the hackage release of HLS 1.9.1

@cumber It is in HEAD but apparently did not make it into the hackage release of 1.9.1:

build-depends: hls-call-hierarchy-plugin ^>= 1.1

https://hackage.haskell.org/package/haskell-language-server-1.9.1.0/src/haskell-language-server.cabal

You can see the builds failed with the expected rejecting: hls-call-hierarchy-plugin-1.2.0.0 line.

Perhaps a hackage revision could fix this?

[cumber]

@tbidne Yes, I'm aware of that because such a revision was made to HLS 1.9.0.0.

But then 1.9.1.0 was pushed to Hackage with the old version bounds, so it doesn't work again. We need another revision.

[juhp]

https://download.copr.fedorainfracloud.org/results/petersen/haskell-language-server/fedora-rawhide-x86_64/05634904-haskell-language-server/ ->
https://download.copr.fedorainfracloud.org/results/petersen/haskell-language-server/fedora-rawhide-x86_64/05634904-haskell-language-server/build.log.gz

[__2] next goal: hls-call-hierarchy-plugin (dependency of
haskell-language-server +callhierarchy)
[__2] rejecting: hls-call-hierarchy-plugin-1.2.0.0 (conflict:
haskell-language-server +callhierarchy => hls-call-hierarchy-plugin^>=1.1)
[__2] trying: hls-call-hierarchy-plugin-1.1.0.0
[__3] next goal: hls-plugin-api (dependency of haskell-language-server)
[__3] rejecting: hls-plugin-api-1.6.0.0 (conflict: hls-call-hierarchy-plugin
=> hls-plugin-api^>=1.5)
[__3] rejecting: hls-plugin-api-1.5.0.0 (conflict: haskell-language-server =>
hls-plugin-api^>=1.6)

It's not enabled in CI or should it be disabled by default?

[michaelpj]

This is still a problem.

[michaelpj]

I published a revision to 1.9.1.0. Revisions are tricky!