Skip to content

Definitive guide for how things should be done #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joyfulmantis opened this issue May 16, 2023 · 1 comment
Open

Definitive guide for how things should be done #3597

joyfulmantis opened this issue May 16, 2023 · 1 comment
Labels
type: enhancement New feature or request

Comments

@joyfulmantis
Copy link
Collaborator

There are a bunch of decisions where there are multiple solutions with different advantages and drawbacks.

Some of the issues I have stumbled over so far have been:

  • The appropriate scope of individual plugins. When to write your feature into an existing plugin, and when to write a new plugin. For example: Should plugins that refactor code be written into the hls-refactor-plugin, or be standalone plugins?
  • When should projects use use vs useWithStale vs useWithStaleFast. For example, should a plugin that modifies code rely on useWithStale? (More consistently available with the possibility of corrupting code)

I imagine there are more of these issues where there is no obvious solution, with advantages and drawbacks for each available solution. Once more of these issues have been listed, for the consistency of the project, it would be beneficial for the team to lay out the project's chosen way of resolving these issues. This way, future features can have such decisions taken into consideration, and old code can be progressively refactored to adhere to such decisions.

@michaelpj
Copy link
Collaborator

I am at least planning to write some haddock for things at Zurihac and I'll cover the use* functions at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants