-
-
Notifications
You must be signed in to change notification settings - Fork 390
support module name and split out module name in qualified name #3957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Data.List.length
Data.List.length
Data.List.length
Two design decisions of step 2 need to be nail down.
|
Hmm. Why do we need to go into the source code? Don't we have the
Wait, we currently highlight the parens? That's surprising! Is that because GHC gives that as part of the span? |
Yes, HieAst gives span of |
That seems... surprising to me. The span includes all the other text, but the |
You can see that from the renamed source as well. If my memory does not fail me, I was once saw an GHC issue about this handling of qualified name long time ago, but could not find it since I forget about the keyword to search for it. Turn out it is the same for |
…accuracy by traversing the hieAst along with source code (#3958) fix #3957 Things have been done: 1. Switch `Name` to `Identifier` in the implementation and add `ModuleName` to the `HsSemanticTokenType` 2. Strip ``` ` ` ``` and `()`, and split out qualified names. e.g.``` `Preclude.length` ``` to ```Preclude.``` `length` 3. add tokenizer to walk ast with the souce rope to get more accurate result and faster. Should fix #3983. 4. add type sig to semanticConfig's TH result
Mainly for
quolified names
.Semantic highlighting looks worse than syntax highlighting for quolified name.
range
ofName
for quolified name include the module part and the name part as a whole.Two steps to solve the problems.
(Prelude.+), `Data.List.elem`
Semantic tokens: add module name support and improve performance and accuracy by traversing the hieAst along with source code #3958The text was updated successfully, but these errors were encountered: