Should we ignore `-Werror` in HLS?

[pepeiborra]

Currently -Werror breaks type checking in the presence of warnings. That is, hover and other LSP features stop working or use stale data.

[ndmitchell]

I think simply discarding -Werror is probably the best approach. People use Werror to really say "fail if there are any warnings", and that's something we definitely don't want to do in an IDE, so best ignore it and keep going.

The other option would be to remove it then retroactively upgrade the warnings to errors, which means people see the same thing on the command line as in the IDE. I'd be OK with that too.

[runeksvendsen]

I'm still experiencing this issue in the repo https://github.com/input-output-hk/cardano-node, for example when working with the cardano-api package.

NB: In this repo, -Werror is specified in the cabal.project file for cardano-api: https://github.com/input-output-hk/cardano-node/blob/master/cabal.project#L17.

[jneira]

Ok, thanks for noting it, reopening issue