Skip to content

Fix a bug in completions #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Fix a bug in completions #1265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7c0ca6
Fix a bad case of boolean blindness
pepeiborra Jan 26, 2021
fa03af8
Merge branch 'master' into bool-blindness
Ailrun Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ghcide/src/Development/IDE/Plugin/HLS.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,10 +472,17 @@ makeCompletions sps lf ideState params@(CompletionParams (TextDocumentIdentifier
consumeCompletionResponse :: Int -> CompletionResponseResult -> (Int, CompletionResponseResult)
consumeCompletionResponse limit it@(CompletionList (CompletionListType _ (List xx))) =
case splitAt limit xx of
-- consumed all the items, return the result as is
(_, []) -> (limit - length xx, it)
(xx', _) -> (0, CompletionList (CompletionListType False (List xx')))
-- need to crop the response, set the 'isIncomplete' flag
(xx', _) -> (0, CompletionList (CompletionListType isIncompleteResponse (List xx')))
consumeCompletionResponse n (Completions (List xx)) =
consumeCompletionResponse n (CompletionList (CompletionListType False (List xx)))
consumeCompletionResponse n (CompletionList (CompletionListType isCompleteResponse (List xx)))

-- boolean disambiguators
isCompleteResponse, isIncompleteResponse :: Bool
isIncompleteResponse = True
isCompleteResponse = False

getPrefixAtPos :: LSP.LspFuncs Config -> Uri -> Position -> IO (Maybe VFS.PosPrefixInfo)
getPrefixAtPos lf uri pos = do
Expand Down