Skip to content

Do not error out on failed rewrite #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Do not error out on failed rewrite #1269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ghcide/src/Development/IDE/Plugin/CodeAction.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,10 @@ codeAction lsp state _ (TextDocumentIdentifier uri) _range CodeActionContext{_di
, Just ps <- [annotatedPS]
, Just dynflags <- [df]
, (title, graft) <- suggestExactAction exportsMap dynflags ps x
, let edit = either error id $
rewriteToEdit dynflags uri (annsA ps) graft
, Right edit <-
[ -- either (Left . traceShow) Right $
rewriteToEdit dynflags uri (annsA ps) graft
]
]
actions'' = caRemoveRedundantImports parsedModule text diag xs uri
<> actions
Expand Down