-
-
Notifications
You must be signed in to change notification settings - Fork 391
Add haskell.nix shell #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add haskell.nix shell #1386
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
254e8b3
Add haskell.nix shell
hamishmack 89515a2
Update haskell.nix
hamishmack d14aa74
Update haskell.nix
hamishmack b951e85
Update haskell.nix
hamishmack 1851f89
Try adding github action
hamishmack 2e95510
Change action name
hamishmack 8cc396a
macos timed out or something building GHC
hamishmack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: HaskellNix | ||
|
|
||
| on: [pull_request] | ||
| jobs: | ||
| nix: | ||
| runs-on: ${{ matrix.os }} | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ghc: ['ghc8104'] | ||
| os: [ubuntu-latest] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| submodules: true | ||
| - uses: cachix/install-nix-action@v12 | ||
| with: | ||
| nix_path: nixpkgs=channel:nixos-20.03 | ||
| - uses: cachix/cachix-action@v8 | ||
| with: | ||
| name: haskell-language-server | ||
| authToken: ${{ secrets.HLS_CACHIX_AUTH_TOKEN }} | ||
| - run: nix-shell haskell.nix -A shell --argstr compiler-nix-name ${{ matrix.ghc }} --run "cabal update && cabal build" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| # This file is an alternative to shell.nix that uses haskell.nix | ||
| # instead of the haskell package set from nixpkgs. | ||
| # | ||
| # To run the shell from this file run: | ||
| # | ||
| # nix-shell haskell.nix -A shell | ||
| # | ||
| # Significant differences to shell.nix: | ||
| # | ||
| # * It uses the `nixpkgs-unstable` pin of nixpkgs from haskell.nix | ||
| # instead of the niv pin (this will increase the chances of getting | ||
| # a cache hit when using the haskell.nix binary cache). | ||
| # | ||
| # * Haskell.nix reads the `source-repository-package` config from | ||
| # the `cabal.project` and other info from `plan.json`. This means | ||
| # it does not depend on `nix/default.nix` and there is no list | ||
| # of the projects packages in this file to update. | ||
| # | ||
| # Maintaining this file | ||
| # | ||
| # * Bump the haskell.nix version using `niv update haskell.nix`. | ||
| # This will update the hackage snapshot used to build the | ||
| # dependencies of the project and any `tools` set to `latest` below | ||
| # will be updated to the latest version in that snapshot. | ||
| # | ||
| { compiler-nix-name ? "ghc8104" | ||
| , withHoogle ? false | ||
| } : | ||
| let | ||
| sources = import nix/sources.nix; | ||
| haskellNix = import sources."haskell.nix" {}; | ||
| pkgs = import haskellNix.sources.nixpkgs-unstable haskellNix.nixpkgsArgs; | ||
| project = pkgs.haskell-nix.cabalProject' { | ||
| inherit compiler-nix-name; | ||
| src = pkgs.haskell-nix.haskellLib.cleanGit { | ||
| name = "haskell-language-server"; | ||
| src = ./.; | ||
| }; | ||
| }; | ||
| in project // { | ||
| shell = project.shellFor { | ||
| inherit withHoogle; | ||
| packageSetupDeps = false; | ||
| buildInputs = with pkgs; [ | ||
| # Add tools from nixpkgs here | ||
| ] ++ builtins.attrValues ( | ||
| # Because the exe name is not the pacakge name | ||
| # we can't put `opentelemetry-extra` in the `tools` | ||
| pkgs.haskell-nix.hackage-package { | ||
| inherit compiler-nix-name; | ||
| name = "opentelemetry-extra"; | ||
| version = "latest"; | ||
| }).components.exes; | ||
| tools = { | ||
| # Tools from hackage (replace `latest` with a version number to pin) | ||
| cabal = "latest"; | ||
| hlint = "latest"; | ||
| ormolu = "latest"; | ||
| stylish-haskell = "latest"; | ||
| }; | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
haskell-language-serverCachix account is limited to 5GB, so this won't work. I recommend using a different Cachix account for the haskell.nix artifacts, I can set up the token if you share it via email ([email protected]).To test it, you will have to open the PR from a GitHub.com/haskell/haskell-language-server branch, otherwise the GitHub action cannot see the token. I've given you push access
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've set up the public Cachix account
haskell-nix-language-serverand the secretHLS_NIX_CACHIX_AUTH_TOKENThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I just saw this. Do you still need me to do this?
I tried pushing the hkm/haskell-nix branch to haskell/haskell-language-server, but got:
It used quite a lot of github minutes building GHC. Is it possible (and would it make sense) to use the IOHK cache instead of cachix (or better yet as an upstream cache if that is possible)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github says that it is awaiting your response:
It makes sense to use the IOHK cache, as long as it freely accessible and also provides Mac OS builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamishmack hi, some update on this?