Skip to content

Conversation

pepeiborra
Copy link
Collaborator

We no longer depend on ghc-lib so it's cleanup time

@anka-213
Copy link
Contributor

anka-213 commented May 2, 2021

Oh, we don't? Then I should probably also remove all the new references to it in this PR #1649.

What was it used for before and what has changed?

We no longer depend on ghc-lib so it's cleanup time
@pepeiborra
Copy link
Collaborator Author

Oh, we don't? Then I should probably also remove all the new references to it in this PR #1649.

What was it used for before and what has changed?

We dropped the dependency in #1366

@anka-213
Copy link
Contributor

anka-213 commented May 2, 2021

Ah, thanks!

Copy link
Collaborator

@ndmitchell ndmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label May 2, 2021
@mergify mergify bot merged commit 8f089d4 into master May 2, 2021
category: Development
build-type: Simple
extra-source-files:
include/ghc-api-version.h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like actual file is not deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants