Skip to content

Workaround for GHC 8.10.5 on macOS #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Workaround for GHC 8.10.5 on macOS #1931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfebb2b
Workaround for GHC 8.10.5 on macOS
konn Jun 16, 2021
af36eff
Removes unnecessary env specification
konn Jun 16, 2021
25f0e9a
Also adds workaround to test CI
konn Jun 16, 2021
3154ccb
Merge branch 'master' into fix-ghc-8105-macos-build
konn Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ jobs:
ghc: '8.8.3' # fails due to segfault
- os: windows-latest
ghc: '8.8.2' # fails due to error with Cabal
- os: macOS-latest
ghc: '8.10.5' # https://gitlab.haskell.org/ghc/ghc/-/issues/19968
include:
- os: windows-latest
ghc: '8.10.2.2' # only available for windows and choco
Expand Down Expand Up @@ -74,6 +72,12 @@ jobs:
run: |
echo "GHC_VERSION=$GHC_VER" >> $GITHUB_ENV

- name: Tentative Workaround for GHC 8.10.5 on macOS
if: matrix.os == 'macOS-latest' && matrix.ghc == '8.10.5'
run: |
echo "# uninstalling CommandLineTools (see https://github.com/haskell/haskell-language-server/issues/1913#issuecomment-861667786)"
sudo rm -rf /Library/Developer/CommandLineTools

- name: Build Server
# Try building it twice in case of flakey builds on Windows
run: |
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,6 @@ jobs:
# This build get stuck frequently
# - os: windows-latest
# ghc: '8.6.4'
exclude:
# Not able to build 'network' package
# See https://gitlab.haskell.org/ghc/ghc/-/issues/19968
- os: macOS-latest
ghc: '8.10.5'

steps:
- if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
Expand Down Expand Up @@ -98,6 +93,12 @@ jobs:
echo "CABAL_STORE_DIR=~/.cabal/store" >> $GITHUB_ENV
echo "CABAL_PKGS_DIR=~/.cabal/packages" >> $GITHUB_ENV

- name: Tentative Workaround for GHC 8.10.5 on macOS
if: matrix.os == 'macOS-latest' && matrix.ghc == '8.10.5'
run: |
echo "# uninstalling CommandLineTools (see https://github.com/haskell/haskell-language-server/issues/1913#issuecomment-861667786)"
sudo rm -rf /Library/Developer/CommandLineTools

# Needs to be before Cache Cabal so the cache can detect changes to the modified cabal.project file
- if: ${{ needs.pre_job.outputs.should_skip != 'true' && matrix.ghc == '9.0.1' }}
name: Use modified cabal.project for ghc9
Expand Down