Reorganize github workflows and use specific label [skip circleci]

[jneira]

• With this pr circle ci and github workflow will be skipped with left bracket skip ci right bracket in the title or description

[pepeiborra]

Instead of adding a condition to every step, would it be possible to generate the empty matrix?

[jneira]

hmm interesting suggestion, not sure if it is possible, will investigate

[jneira]

hmm interesting suggestion, not sure if it is possible, will investigate

I've investigated a little bit and it seems you can set the matrix contents in a previous job. However it seems to be a little bit complex: https://stackoverflow.com/a/65434401/49554
But i've checked the behavior making the matrix empty and it seems it is not possible: https://github.com/jneira/haskell-language-server/actions/runs/1378514886

[jneira]

I've tried another approach to make cleaner main job steps: create a post_job which will be a summary of all main jobs and will be succesful if those jobs are skipped by the pre_job.
This not only will clean out the skipping logic from main jobs but will let us have only three jobs as required to merge a pr: the three summary post jobs. We will not have to update required checks when adding jobs.

The caveat is we will not be able to remove specific jobs as required in the github project settings but only in the workflow file.

[jneira]

Examples from my repo:

• A job that is skipped cause the same commit was succesful in other workflow (thanks to skip-dplicate-jobs), succesful in seconds: https://github.com/jneira/haskell-language-server/actions/runs/1387098394
• A workflow failed cause a failed main job makes the post job fail as well: https://github.com/jneira/haskell-language-server/actions/runs/1387137230
• A succesful workflow: https://github.com/jneira/haskell-language-server/actions/runs/1387137228

I've still not tested a cancelled job (when you cancel in the github gui you cancel the entire workflow) but i think it will work too

[jneira]

Will have to update required checks after merging this. Will force push without skipping ci

[jneira]

I've found a issue with the [skip ci] label, it seems once you have a run with the label in the title or body, you cant revert it deleting it and rerunning jobs. The skip-duplicate-jobs skips the build cause it find another previous one with the same files, even if the commit is different (with a force push or an empty commit):

Skip execution because the exact same files have been successfully checked in https://github.com/haskell/haskell-language-server/actions/runs/1387152272

https://github.com/haskell/haskell-language-server/runs/4018414106 was skipped in this pr cause at that time the pr had [skip ci] in its title. But if you rerun it again, it does not take in account the actual title/desc without [skip ci]

So if someone uses that label incorrectly the pr could not be changed to not skip ci, but changing some file.
Not sure if this can be a problem in practice tohugh.

[jneira]

I think it is better to remove manual skip ci, let skip-dplicate-jobs do its job and use a specific label for circle ci
But i will keep post_job's as they are an improvement in its own.

[jneira]

@pepeiborra i removed the setup ci cache step here, as it seems is a no-op, let me know if you think it should be kept

[jneira]

The github workflow will make a comment in the pr to skip circleci as well. circli will look at comments too

See example here: jneira#44