Skip to content

Suggest hiding imports when local definition exists #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yoshitsugu
Copy link
Contributor

@yoshitsugu yoshitsugu commented Nov 1, 2021

pull request for #2114
I'm new here so please point out if this fix has any problems

@jneira jneira requested review from Ailrun and jneira November 1, 2021 14:03
@jneira
Copy link
Member

jneira commented Nov 2, 2021

@yoshitsugu thanks for the pr, i am rerunning ci as it is failing with transient errors lately

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great and it has the required tests, thanks!

@jneira jneira added the merge me Label to trigger pull request merge label Nov 3, 2021
@mergify mergify bot merged commit e9e8e71 into haskell:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggesting "Hiding other imports"-like action when ambiguity includes local definition
2 participants