-
-
Notifications
You must be signed in to change notification settings - Fork 391
Not suggest exported imports #2329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -32,3 +32,16 @@ library | |||
default-extensions: | |||
DataKinds | |||
TypeOperators | |||
|
|||
test-suite tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow the plugin had no test suite??? Many thanks for adding it, a great contribution in its own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to add it to the github workflow to run them in ci, adding an entry like
haskell-language-server/.github/workflows/test.yml
Lines 207 to 209 in a0cd84b
- if: matrix.test | |
name: Test hls-refine-imports-plugin test suite | |
run: cabal test hls-refine-imports-plugin --test-options="-j1 --rerun-update" || cabal test hls-refine-imports-plugin --test-options="-j1 --rerun" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-refine-imports-plugin --test-options="-j1 --rerun" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I'll fix.
Many thanks for your new contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving this plugin and adding tests!
Co-authored-by: Michael Peyton Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many thanks!
I attempted to fix #2079
I'm not familiar with GHC AST kind things. I'd be happy to get some advice if anyone has more smart way to implement this.