Skip to content

#2418 Also use .hlint.yaml fixity rules when HLINT_ON_LIB_GHC not defined #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 11, 2021
Merged

#2418 Also use .hlint.yaml fixity rules when HLINT_ON_LIB_GHC not defined #2464

merged 7 commits into from
Dec 11, 2021

Conversation

eddiemundo
Copy link
Collaborator

@eddiemundo eddiemundo commented Dec 10, 2021 •
edited
Loading

Fixes #2418

If #1325 is merged then we can modify this fix to remove the ghc-lib-parser-ex dependency.

jneira
jneira reviewed Dec 10, 2021
View reviewed changes
jneira
jneira approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic including its appropiate regression test, thanks!

@jneira jneira added the merge me Label to trigger pull request merge label Dec 11, 2021
@mergify mergify bot merged commit f128085 into haskell:master Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hlint fixity issues
2 participants
@eddiemundo @jneira