Skip to content

test: repro for #2662: extend import list miss separator #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 31, 2022
Merged

test: repro for #2662: extend import list miss separator #2664

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e10843e
test: repro for #2662: extend import list miss separator
guibou Jan 31, 2022
016ff73
test: Add test for import list extension with prefix ctor
guibou Jan 31, 2022
3f9a455
Merge branch 'master' into repro_2662
jneira Jan 31, 2022
c087e64
test: Mark failing test explicitly with GHC 9.2
guibou Jan 31, 2022
6e2cff5
test: use knownBrokenForGhcVersions instead of ignoreForGHC92
guibou Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions ghcide/test/exe/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1520,6 +1520,36 @@ extendImportTests = testGroup "extend import actions"
, "import ModuleA as A (stuffB, (.*))"
, "main = print (stuffB .* stuffB)"
])
, knownBrokenForGhcVersions [GHC92] "missing comma. #2662" $ testSession "extend single line import with infix constructor" $ template
[]
("ModuleB.hs", T.unlines
[ "module ModuleB where"
, "import Data.List.NonEmpty (fromList)"
, "main = case (fromList []) of _ :| _ -> pure ()"
])
(Range (Position 2 5) (Position 2 6))
["Add NonEmpty((:|)) to the import list of Data.List.NonEmpty"]
(T.unlines
[ "module ModuleB where"
, "import Data.List.NonEmpty (fromList, NonEmpty ((:|)))"
, "main = case (fromList []) of _ :| _ -> pure ()"
])
, knownBrokenForGhcVersions [GHC92] "missing comma. #2662" $ testSession "extend single line import with prefix constructor" $ template
[]
("ModuleB.hs", T.unlines
[ "module ModuleB where"
, "import Prelude hiding (Maybe(..))"
, "import Data.Maybe (catMaybes)"
, "x = Just 10"
])
(Range (Position 3 5) (Position 2 6))
["Add Maybe(Just) to the import list of Data.Maybe"]
(T.unlines
[ "module ModuleB where"
, "import Prelude hiding (Maybe(..))"
, "import Data.Maybe (catMaybes, Maybe (Just))"
, "x = Just 10"
])
, testSession "extend single line import with type" $ template
[("ModuleA.hs", T.unlines
[ "module ModuleA where"
Expand Down