Skip to content

hls-plugin-api: add lower bounds #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2022
Merged

hls-plugin-api: add lower bounds #3022

merged 4 commits into from
Jul 8, 2022

Conversation

Bodigrim
Copy link
Contributor

@Bodigrim Bodigrim commented Jul 6, 2022

Before opentelemetry-0.4 SpanInFlight is not exported.
Before dependent-sum-0.7 GCompare is not coming from some, but is defined elsewhere, which leads to incompatibility with lsp.

As a Hackage trustee, I made a matching revision:
https://hackage.haskell.org/package/hls-plugin-api-1.4.0.0/revisions/

Before `opentelemetry-0.4` `SpanInFlight` is not exported.
Before `dependent-sum-0.7` `GCompare` is not coming from `some`, but is defined elsewhere, which leads to incompatibility with `lsp`.
@Bodigrim Bodigrim requested review from jneira and berberman as code owners July 6, 2022 20:25
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jul 6, 2022
@mergify mergify bot merged commit 12095b2 into master Jul 8, 2022
@Bodigrim Bodigrim deleted the Bodigrim-patch-5 branch July 9, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants